Skip to content

model: load YaRN beta metadata for laguna models - #30331

Merged
taronaeo merged 1 commit into
ggml-org:masterfrom
accaldwell:fix/laguna-xs
Oct 13, 2026
Merged

taronaeo merged 1 commit into
ggml-org:masterfrom
accaldwell:fix/laguna-xs

Conversation

@accaldwell

Copy link
Copy Markdown

Overview

  • src/models/laguna.cpp previously did not load YaRN beta metadata from the model file. In the case of Laguna XS 2.1, this was falling back to a llama.cpp default 32 value for yarn_beta_fast instead of using the model file's 64. This PR loads yarn_beta_fast and yarn_beta_slow from the model file.

Additional information

Tested with Laguna XS 2.1, Q8_0 on Vulkan

  • Perplexity nearly identical on three 8k chunks of the wikitext-2 test set. yarn_beta_fast 32: 10.1622 ± 0.29239 yarn_beta_fast 64: 10.1553 ± 0.29313

  • Text generation quality was similar across a few temperature=0 prompts, slightly better in one case.

Requirements

  • I have read and agree with the contributing guidelines
  • A test is included per the contributing guidelines
  • AI usage disclosure: YES. claude/Opus5.5 found this issue and codex/Sol6.1 fixed it, wrote the test, and ran the tests

@github-actions github-actions Bot added model Model specific testing Everything test related labels Oct 11, 2026

@CISC CISC left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the test, otherwise OK.

@accaldwell

Copy link
Copy Markdown
Author

Removed the test per request

@CISC CISC added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Oct 12, 2026
@taronaeo
taronaeo merged commit f441d2d into ggml-org:master Oct 13, 2026
19 checks passed
@accaldwell
accaldwell deleted the fix/laguna-xs branch October 14, 2026 08:16
edwardyoon pushed a commit to edwardyoon/focus-llama that referenced this pull request Oct 24, 2026
Assisted-by: Codex

Co-authored-by: Adam Caldwell <accaldwell@users.noreply.github.com>
auRose94 pushed a commit to auRose94/llama.cpp that referenced this pull request Oct 28, 2026
Assisted-by: Codex

Co-authored-by: Adam Caldwell <accaldwell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. model Model specific testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants