Skip to content

cuda : fix -Wtautological-compare in fattn vec dispatch - #30519

Merged
IMbackK merged 1 commit into
ggml-org:masterfrom
angt:cuda-fix-wtautological-compare-in-fattn-vec-dispatch
Oct 17, 2026
Merged

IMbackK merged 1 commit into
ggml-org:masterfrom
angt:cuda-fix-wtautological-compare-in-fattn-vec-dispatch

Conversation

@angt

@angt angt commented Oct 14, 2026

Copy link
Copy Markdown
Member

Overview

Normalize F32 KV types to F16 before FA dispatch, removing comparisons such as GGML_TYPE_F16 == GGML_TYPE_F16.

Additional information

Requirements

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@angt
angt requested a review from a team as a code owner October 14, 2026 13:22
@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning CUDA Related to the CUDA backend labels Oct 14, 2026
@JohannesGaessler JohannesGaessler added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Oct 17, 2026
@IMbackK
IMbackK merged commit 9d1e036 into ggml-org:master Oct 17, 2026
18 checks passed
edwardyoon pushed a commit to edwardyoon/focus-llama that referenced this pull request Oct 24, 2026
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
MuFengMuXue pushed a commit to MuFengMuXue/llama.cpp-gfx906 that referenced this pull request Oct 26, 2026
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
auRose94 pushed a commit to auRose94/llama.cpp that referenced this pull request Oct 28, 2026
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CUDA Related to the CUDA backend ggml changes relating to the ggml tensor library for machine learning merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants