Repository navigation
fix: lightonocr does not require longest edge to always be 1540, native resolution is the default - #30600
Merged
Conversation
…ve resolution is the default Assisted-by: Codex
github-actions
Bot
added
testing
ngxson
approved these changes
Oct 15, 2026
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 24, 2026
…ive resolution is the default (ggml-org#30600) Assisted-by: Codex
auRose94
pushed a commit
to auRose94/llama.cpp
that referenced
this pull request
Oct 28, 2026
…ive resolution is the default (ggml-org#30600) Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Current code for resizing LightOnOCR models upscales images below the cap until their longest edge is 1540. The expected behavior is to use native resolution below that cap, which is important for performance.
A 463x463 image currently becomes 1540x1540. With this fix it becomes 476x476 after patch alignment. The regression test covers small and large images.
Requirements