Repository navigation
qwen: reshape output to 2d instead of 3d - #30823
Merged
Merged
Conversation
CISC
approved these changes
Oct 19, 2026
CISC
left a comment
CISC
left a comment
Member
There was a problem hiding this comment.
Could have sworn there was a reason for it, perhaps outdated?
ggerganov
approved these changes
Oct 19, 2026
|
|
||
| // Final reshape: [head_dim, n_heads, n_tokens, n_seqs] -> [n_tokens, n_seqs, n_heads * head_dim] | ||
| ggml_tensor * final_output = ggml_reshape_3d(ctx0, attn_out_norm, head_v_dim * num_v_heads, n_seq_tokens, n_seqs); | ||
| // Final reshape: [head_dim, n_heads, n_tokens, n_seqs] -> [n_tokens * n_seqs, n_heads * head_dim] |
Member
There was a problem hiding this comment.
Could you also fix the comments:
Suggested change
| // Final reshape: [head_dim, n_heads, n_tokens, n_seqs] -> [n_tokens * n_seqs, n_heads * head_dim] | |
| // Final reshape: [head_dim, n_heads, n_tokens, n_seqs] -> [n_heads * head_dim, n_tokens * n_seqs] |
Comment on lines
476
to
477
Member
There was a problem hiding this comment.
Is this reshape still needed?
am17an
added
the
merge ready
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 24, 2026
MuFengMuXue
pushed a commit
to MuFengMuXue/llama.cpp-gfx906
that referenced
this pull request
Oct 26, 2026
* qwen: reshape output to 2d instead of 3d * remove final reshape, fix comments
auRose94
pushed a commit
to auRose94/llama.cpp
that referenced
this pull request
Oct 28, 2026
* qwen: reshape output to 2d instead of 3d * remove final reshape, fix comments
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes the final output shape to be
[n, n_tokens * n_seqs]instead of[n, n_tokens, n_seqs]for better performance during multi-seq decode.Additional information
Requirements