Skip to content

ui: Models Manager as Route + UI improvements - #30988

Merged
ggerganov merged 6 commits into
masterfrom
allozaur/feat/models-manager-as-route
Oct 24, 2026
Merged

ggerganov merged 6 commits into
masterfrom
allozaur/feat/models-manager-as-route

Conversation

@allozaur

Copy link
Copy Markdown
Contributor

Overview

Moves Models Manager view to a separate route, improves the UI elements appearance.

Requirements

Models now lives at #/models instead of a dialog. Discover opens as a
standalone dialog over it, and leaving the page returns to the chat it
was opened from.

Assisted by: Claude (Opus 5.5 Medium)
Give the models page a page header with the Discover action, calmer
column labels, tinted section and family headers, and an empty state.
Load the model list on a direct visit, slide the detail pane over the
table below xl, and draw the filter toggles as one box matching the
context select, with room for their shadow.

Assisted by: Claude (Opus 5.5 Medium)
Assisted by: Claude (Opus 5.5 Medium)
Record the models page's way back after every navigation, so Back,
a typed URL or a reload no longer return to a stale chat. Escape
closes the detail pane, then leaves the page. Gate every Discover
entry point on one shared check, recheck the API key on /models,
skip the duplicate router fetch on a direct load, and share the
route load between pages.

Assisted by: Claude (Opus 5.5 Medium)
Open the models manager's detail pane in a drawer, from the right on
desktop and from the bottom on a phone, instead of an inline side
panel and a full-screen cover. Pad the pane on both sides, drop its
close button on a phone, and assert that filtered rows are gone from
the page rather than merely hidden.

Assisted by: Claude (Opus 5.5 Medium)
A click anywhere on a model or quant row opens it, unless it lands on
one of the row's own controls (load toggle, actions menu). The name
button stays the keyboard path to the same action.

Assisted by: Claude (Opus 5.5 Medium)
Copilot AI balanced review requested due to automatic review settings October 22, 2026 15:30
@allozaur
allozaur requested a review from a team as a code owner October 22, 2026 15:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@ServeurpersoCom ServeurpersoCom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Tested on my prod, everything works as expected, nothing to say on the code

Image

@allozaur allozaur added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Oct 22, 2026
@ggerganov
ggerganov merged commit e168e04 into master Oct 24, 2026
8 checks passed
jiangchuanso added a commit to jiangchuanso/llama.cpp-zh-el8 that referenced this pull request Oct 25, 2026
…elsManager

The 16 upstream commits include ggml-org#30988 "Models Manager as Route + UI
improvements", a large UI refactor that turned the models manager from a
dialog into a route and rewrote its components. Conflicts:

- modify/delete on dialogs/DialogManageModels.svelte: upstream deleted it
  (moved to routes/models/+page.svelte); accepted the deletion. Its i18n
  strings are carried by the shared ModelsManager components and the new
  route page.
- 4 content conflicts in ModelsManager/*: upstream renamed settingsStore to
  uiStore and dropped the t() layer (upstream ships untranslated UI); kept
  the fork's t() wrappers and the upstream store rename, and re-wrapped the
  new Empty-state component strings in t().
- routes/models/+page.svelte (new upstream route): wrapped its heading,
  description and Discover button in t(), added the zh-CN entries.

All other UI diffs in this batch were structural/styling only (ggml-org#30978).
i18n dictionary now 854 keys.

Assisted-by: CodeBuddy
auRose94 pushed a commit to auRose94/llama.cpp that referenced this pull request Oct 28, 2026
* ui : move models manager to its own route, keep Discover as a dialog

Models now lives at #/models instead of a dialog. Discover opens as a
standalone dialog over it, and leaving the page returns to the chat it
was opened from.

Assisted by: Claude (Opus 5.5 Medium)

* ui : polish the models page layout and filters

Give the models page a page header with the Discover action, calmer
column labels, tinted section and family headers, and an empty state.
Load the model list on a direct visit, slide the detail pane over the
table below xl, and draw the filter toggles as one box matching the
context select, with room for their shadow.

Assisted by: Claude (Opus 5.5 Medium)

* ui : round the models table family headers

Assisted by: Claude (Opus 5.5 Medium)

* ui : fix models page navigation and Discover gating

Record the models page's way back after every navigation, so Back,
a typed URL or a reload no longer return to a stale chat. Escape
closes the detail pane, then leaves the page. Gate every Discover
entry point on one shared check, recheck the API key on /models,
skip the duplicate router fetch on a direct load, and share the
route load between pages.

Assisted by: Claude (Opus 5.5 Medium)

* ui : show model details in a drawer

Open the models manager's detail pane in a drawer, from the right on
desktop and from the bottom on a phone, instead of an inline side
panel and a full-screen cover. Pad the pane on both sides, drop its
close button on a phone, and assert that filtered rows are gone from
the page rather than merely hidden.

Assisted by: Claude (Opus 5.5 Medium)

* ui : make whole models table rows clickable

A click anywhere on a model or quant row opens it, unless it lands on
one of the row's own controls (load toggle, actions menu). The name
button stays the keyboard path to the same action.

Assisted by: Claude (Opus 5.5 Medium)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. server/ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants