Repository navigation
common : fix ngram cache draft out of bounds read - #31161
Open
ashokram-si wants to merge 1 commit into
Open
ashokram-si wants to merge 1 commit into
ashokram-si wants to merge 1 commit into
Conversation
When input size is less than the ngram size, the start index becomes negative. Because the type is unsigned, it wraps around and causes a heap buffer overflow when reading the draft buffer. Adds a simple bounds check to break early when the ngram size exceeds available tokens. Fixes ggml-org#30724
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #30724
When input size is less than the ngram size, the start index becomes negative. Because the type is unsigned, it wraps around and causes a heap buffer overflow when reading the draft buffer.
Adds a simple bounds check to break early when the ngram size exceeds available tokens.
Additional information
Tested locally. The new test-ngram-cache fails on the old code when built with ASan/UBSan, and passes after the fix.
Requirements