Skip to content

ui: fix system message row stretching to full prompt height in WebKit - #31246

Merged
ggerganov merged 1 commit into
masterfrom
allozaur/fix/system-message-height
Oct 27, 2026
Merged

ggerganov merged 1 commit into
masterfrom
allozaur/fix/system-message-height

Conversation

@allozaur

@allozaur allozaur commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Overview

The expand button wrapping the system message card defaulted to inline-block. WebKit takes an inline-block's baseline from its last line even when that line is clipped by the card's max-height, so the row grew to the height of the whole prompt and left a large empty gap below the card. Make the button a block so the row matches the card.

BEFORE AFTER
Screenshot 2026-10-27 at 11 52 44 Screenshot 2026-10-27 at 11 53 03

Requirements

The expand button wrapping the system message card defaulted to
inline-block. WebKit takes an inline-block's baseline from its last
line even when that line is clipped by the card's max-height, so the
row grew to the height of the whole prompt and left a large empty gap
below the card. Make the button a block so the row matches the card.

Assisted-by: Claude (Opus 5.5 Medium)
@allozaur
allozaur requested a review from a team as a code owner October 27, 2026 10:41
Copilot AI balanced review requested due to automatic review settings October 27, 2026 10:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@ggerganov
ggerganov merged commit 3ab37ae into master Oct 27, 2026
6 checks passed
auRose94 pushed a commit to auRose94/llama.cpp that referenced this pull request Oct 28, 2026
…ggml-org#31246)

The expand button wrapping the system message card defaulted to
inline-block. WebKit takes an inline-block's baseline from its last
line even when that line is clipped by the card's max-height, so the
row grew to the height of the whole prompt and left a large empty gap
below the card. Make the button a block so the row matches the card.

Assisted-by: Claude (Opus 5.5 Medium)
yzhou51 pushed a commit to yzhou51/llama.cpp that referenced this pull request Oct 30, 2026
…ggml-org#31246)

The expand button wrapping the system message card defaulted to
inline-block. WebKit takes an inline-block's baseline from its last
line even when that line is clipped by the card's max-height, so the
row grew to the height of the whole prompt and left a large empty gap
below the card. Make the button a block so the row matches the card.

Assisted-by: Claude (Opus 5.5 Medium)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants