Repository navigation
gguf-py: fix np_roundf dropping the sign - #31310
Merged
Merged
Conversation
CISC
approved these changes
Oct 28, 2026
Member
|
Strange though, was verified to have been fixed on |
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@huggingface.co>
Collaborator
Author
|
it's broken on one single version of python:
|
CISC
reviewed
Oct 28, 2026
Member
Funny thing is it only affects certain builds as well, I could never reproduce this (on two different systems). |
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@huggingface.co>
CISC
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
fix for numpy < 2.3 on Python 3.14 making
np_roundfto drop the sign, affecting the output of--outtype q8_0in the conversion scriptRequirements