Repository navigation
renderer: generalize the definition of "space" - #2434
Merged
Merged
Conversation
Contributor
|
Thanks looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the most common U+0020, there are many other types of spaces. For example, U+00A0 is a no-break space, and U+2002 is an en space. When considering whether symbols should be scaled, these more general types of spaces should also be treated as spaces.
Since this behavior is a kind of hack, not all general spaces (e.g., U+00A0) are included, to provide a method to force no scaling. U+2002 was specifically chosen because it is the option used by Kitty.
Kitty has detailed discussions on this, see kovidgoyal/kitty#6750.