Skip to content

renderer: generalize the definition of "space" - #2434

Merged
mitchellh merged 1 commit into
ghostty-org:mainfrom
ofseed:en-space
Oct 12, 2024
Merged

mitchellh merged 1 commit into
ghostty-org:mainfrom
ofseed:en-space

Conversation

@ofseed

@ofseed ofseed commented Oct 12, 2024

Copy link
Copy Markdown
Contributor

In addition to the most common U+0020, there are many other types of spaces. For example, U+00A0 is a no-break space, and U+2002 is an en space. When considering whether symbols should be scaled, these more general types of spaces should also be treated as spaces.

Since this behavior is a kind of hack, not all general spaces (e.g., U+00A0) are included, to provide a method to force no scaling. U+2002 was specifically chosen because it is the option used by Kitty.

Kitty has detailed discussions on this, see kovidgoyal/kitty#6750.

@mitchellh

Copy link
Copy Markdown
Contributor

Thanks looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants