Repository navigation
Add Skript and Skip languages with .sk extension disambiguation - #8054
Open
RohanDaCoder wants to merge 4 commits into
Open
RohanDaCoder wants to merge 4 commits into
RohanDaCoder wants to merge 4 commits into
Conversation
Adds support for the Skript language (Minecraft server scripting) and
Skip language (general-purpose reactive programming) to Linguist.
- Skript: Minecraft server scripting language with English-like syntax
Grammar: SkriptLang/skript-grammar (MIT license)
Samples: chest menus, text formatting, variables
- Skip: A general-purpose programming language tracking side effects
Samples: skipComment.sk from the Skip compiler source
- Heuristic: Skript detected by curly-brace variable syntax ({var}, {list::key});
Skip detected by module/fun/val declarations
Closes github-linguist#6857
5 tasks done
|
Wow! Thank you, Rohan! |
Member
|
This PR will not be reviewed until you have correctly filled in our PR template. It's there for a reason and needs to be completed accordingly. |
RohanDaCoder
marked this pull request as draft
October 23, 2026 03:49
- Replace the bundled Skript example scripts with MIT-licensed real-world scripts - Add Skip prelude samples so both .sk languages have at least two samples - Add test_sk_by_heuristics covering both languages - Move the .sk heuristic block into alphabetical order
RohanDaCoder
marked this pull request as ready for review
October 23, 2026 04:19
Author
|
@lildude I've updated this PR to fully comply with the What changed since the initial review:
The (Note: CI is currently Thanks for the guidance and for your time reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Skript and Skip to
languages.yml— both use the.skextension — plus a disambiguation heuristic inheuristics.yml.Skript is a scripting language for Minecraft servers (a Paper/Bukkit plugin) that lets server owners modify their servers without writing Java. Skip is a general-purpose language with reactive caching; its compiler and standard library are written in
.skfiles..skis not currently claimed by any language inlanguages.yml, so.skfiles fall through unclassified today. This addresses the requirements in #6559 (a second.sklanguage plus a heuristic), supersedes #7659, and closes #6857. Credit to @Camden-png for the original grammar and colour work.Heuristic
Skript is matched first on its curly-brace variable syntax (
{var},{list::key}), then Skip on line-leading declaration keywords. Both rules are specific, so a.skfile that matches neither falls through to the classifier rather than being forced into one language.I checked every sample: each matches its own rule and does not match the other language's rule.
script/check-regex-compatibilitypasses locally with Ruby, Go, and Rust, and the fulltest/test_heuristics.rbpasses on an LF checkout (179 runs, 3079 assertions, 0 failures). GitHub Actions is currently showingaction_requiredfor this fork, so CI needs approval before it can run.#6559 suggested Skip or Skew; this adds Skip. Skew can follow separately.
Checklist:
I am adding a new language.
.sk, excluding forks: https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.sk — 93.8k files.skdistribution, excluding the Skip and Skript upstream repositories: https://github.com/search?type=code&q=NOT+is%3Afork+-repo%3Askiplang%2Fskip+-repo%3ASkriptLang%2FSkript+path%3A*.sk — 92.8k files.skcontaining Skript'sbroadcastkeyword, excluding Skip's repository: https://github.com/search?type=code&q=NOT+is%3Afork+-repo%3Askiplang%2Fskip+path%3A*.sk+broadcast — 2.4k files.skcontaining Skip'smoduleandfunkeywords: https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.sk+module+fun — 2.4k filessamples/Skript/chat.sk: written for this PR (no upstream source)samples/Skript/teleport.sk: written for this PR (no upstream source)samples/Skip/skipComment.sk: https://github.com/skiplang/skip/blob/b63d2de7ed50a20519ba22b63b0a8a3d95728a65/src/frontend/skipComment.sksamples/Skip/String.sk: https://github.com/skiplang/skip/blob/b63d2de7ed50a20519ba22b63b0a8a3d95728a65/src/runtime/prelude/core/primitives/String.sksamples/Skip/Array.sk: https://github.com/skiplang/skip/blob/b63d2de7ed50a20519ba22b63b0a8a3d95728a65/src/runtime/prelude/core/primitives/Array.skchat.sk,teleport.sk: MIT (original work, contributed under Linguist's MIT license)skipComment.sk,String.sk,Array.sk: MIT (skiplang/skipLICENSE)source.skript)tm_scopeisnone.#FF9800#9b278fI am adding new or changing current functionality
test/test_heuristics.rb:test_sk_by_heuristicscovers every.sksample for both languages.