A7-1-1: Exclude compiler generated statements for range based for loops #372

Activity

1. lcartey

   added

   Difficulty-LowA false positive or false negative report which is expected to take <1 day effort to addressA false positive or false negative report which is expected to take <1 day effort to address

   false positive/false negativeAn issue related to observed false positives or false negatives.An issue related to observed false positives or false negatives.

   Impact-Medium

   user-reportIssue reported by an end user of CodeQL Coding StandardsIssue reported by an end user of CodeQL Coding Standards

   on Oct 2, 2023
2. lcartey commented on Oct 25, 2023

   

   lcartey

   on Oct 25, 2023

   ContributorAuthor

   More actions

   As part of this work we should do a systematic analysis of the queries using QL for QL to identify queries reporting Variables as their primary location where the isCompilerGenerated is not included as a condition on the where clause.
3. rvermeulen

   self-assigned this

   on Jan 10, 2024
4. rvermeulen

   added this to Coding Standards Public Development Boardon Jan 23, 2024
5. rvermeulen

   moved this to Scheduled in Coding Standards Public Development Boardon Jan 23, 2024
6. rvermeulen

   moved this from Scheduled to In Progress in Coding Standards Public Development Boardon Jan 23, 2024
7. rvermeulen

   moved this from In Progress to Stretch in Coding Standards Public Development Boardon Jan 30, 2024
8. rvermeulen

   moved this from Stretch to Scheduled in Coding Standards Public Development Boardon Feb 1, 2024
9. rvermeulen

   moved this from Scheduled to In Progress in Coding Standards Public Development Boardon Feb 1, 2024
10. rvermeulen commented on Feb 1, 2024

    

    rvermeulen

    on Feb 1, 2024

    Last edited by rvermeulen

    Contributor

    More actions

    A0-1-1 is already address by @lcartey in b8a527c.
    Cannot replicate the issue for A7-1-1, but testing on open pilot does give a meaningful difference.
    I will exclude compiler generated variables.
11. rvermeulen

    added a commit that references this issue on Feb 1, 2024

    Fix FP reported in github#372

    a6f24b6
12. rvermeulen

    moved this from In Progress to Ready for review in Coding Standards Public Development Boardon Feb 1, 2024
13. knewbury01

    moved this from Ready for review to Done in Coding Standards Public Development Boardon Feb 2, 2024
14. github-merge-queue

    added a commit that references this issue on Feb 2, 2024

    Merge pull request #521 from rvermeulen/rvermeulen/fix-372

    ...

    be2db41
15. knewbury01

    closed this as completedin #521on Feb 2, 2024
16. rvermeulen

    added a commit that references this issue on Feb 13, 2024

    Fix FP reported in github#372

    ef16d02