Allow unsigned PR branch pushes when signed commits are disabled - #32273
Merged
Conversation
Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix merge commit blocking on push paths
Allow unsigned PR branch pushes when signed commits are disabled
May 15, 2026
pelikhan
marked this pull request as ready for review
May 15, 2026 04:41
Collaborator
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a push-signed-commits option to push-to-pull-request-branch so users can opt out of GraphQL signed commits and push directly with git push, which allows merge commits (multiple parents) that the GraphQL createCommitOnBranch mutation cannot represent.
Changes:
- Added
push-signed-commitsconfig option to schema, Go config struct, parser, and handler builder; plumbed aspush_signed_commitsto the JS handler. - In
push_signed_commits.cjs, whensignedCommits === false, skip GraphQL replay and rungit push origin <branch>directly, returning the local HEAD SHA. - Updated docs and added tests + changeset.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/push_to_pull_request_branch.go | Adds PushSignedCommits field and parsing. |
| pkg/workflow/push_to_pull_request_branch_test.go | Test that push-signed-commits: false reaches the handler config. |
| pkg/workflow/compiler_safe_outputs_handlers.go | Emits push_signed_commits in handler config JSON. |
| pkg/parser/schemas/main_workflow_schema.json | Schema entry for the new option. |
| docs/src/content/docs/reference/safe-outputs.md | Mentions option in safe-outputs reference. |
| docs/src/content/docs/reference/safe-outputs-pull-requests.md | Documents option for push-to-pull-request-branch. |
| actions/setup/js/types/handler-factory.d.ts | Declares push_signed_commits in HandlerConfig. |
| actions/setup/js/push_to_pull_request_branch.cjs | Reads option and forwards signedCommits to helper. |
| actions/setup/js/push_to_pull_request_branch.test.cjs | Test for option log line. |
| actions/setup/js/push_signed_commits.cjs | Direct git push branch when signedCommits === false. |
| actions/setup/js/push_signed_commits.test.cjs | Integration test for merge-commit push with signed commits disabled. |
| .changeset/patch-push-signed-commits-opt-out.md | Patch changeset note. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 11/12 changed files
- Comments generated: 0
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Collaborator
|
@copilot merge main and recompile |
…request-branch # Conflicts: # actions/setup/js/create_pull_request.cjs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Collaborator
|
@copilot review all changes, apply SOLID |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Collaborator
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
|
|
Collaborator
|
@copilot merge main and recompile |
…request-branch # Conflicts: # actions/setup/js/update_pull_request.cjs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
What was the bug?
push-to-pull-request-branchcould not push local merge commits: GraphQL signed commits cannot represent multiple parents, and the documentedpush-signed-commits: falseescape hatch was not implemented.How did you fix it?
Workflow configuration
push-signed-commitsto thepush-to-pull-request-branchschema and compiler config.push_signed_commits.Push behavior
push-signed-commits: false, skip GraphQL replay and use authenticatedgit pushdirectly.Docs and release notes