Conversation
Adds complete Hebrew catalogs for both the manifest (2298 entries) and the runtime bundle (6795 entries), covering all 9093 localizable strings. Documents the Hebrew conventions in l10n/README.md alongside the existing Spanish and Chinese sections: the git/UI glossary, imperative masculine singular for command and button titles, third-person present for setting descriptions, verbal nouns for "Confirm <action>" dialog headings, and the rule that a Latin brand never leads a Hebrew title or label. All 379 ICU plural blocks keep their structure with the Hebrew one/two/many/ other categories, placeholders and codicons are preserved verbatim, and no bidi control characters are used.
Member
|
@Y-PLONI awesome! Thank you! Please file those issues. |
Author
|
@eamodio |
Member
|
I'm currently working on the RTL part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a complete Hebrew (
he) localization — all 9093 localizable strings, across both catalogs:package.nls.he.jsonl10n/bundle.l10n.he.jsonRelates to #577.
The catalogs were produced with the existing
scripts/localization-chunks.mjssplit/mergeworkflow, so the keys are byte-identical to the English source (including the non-breaking space inRemote Branch $(git-branch) {0}).Conventions
l10n/README.mdgains a### Hebrew (he)section next to the existing Spanish and Chinese ones, documenting:Confirm <action>wizard step titles, since those render as dialog headings rather than actions.מצב Git, notGit מצב), while a full sentence whose subject is the product reads correctly as-is.Correctness
one/two/many/other) rather than being flattened.{0},{name}), codicons ($(icon-name)), Markdown links andcommand:URIs are preserved verbatim.docs/localization.md. Four duration abbreviations ({days}d {hours}h, …) and the two "Inspect"/"Patch" view container titles are deliberately left in Latin.pnpm run checkandpnpm run test:localization(25/25) both pass.Notes for maintainers
Two things surfaced during this work that are outside the scope of this PR:
dir="rtl", so with a Hebrew display language the text is Hebrew but the layout stays LTR. Happy to open a separate issue with the specific webviews affected.{0}},acccount,layout of **for**, and someeamodio/vscode-gitlenswiki links that now 404. I can file these separately if useful.Checklist
l10n/README.mdand theContributorslist are updated; noCHANGELOG.mdentry, matching how the existingesandzh-cncatalogs were added🤖 Generated with Claude Code