Skip to content

Forwards account-wide issue page sizes - #5850

Open
eamodio wants to merge 1 commit into
mainfrom
bug/core-github-issue-page-size
Open

eamodio wants to merge 1 commit into
mainfrom
bug/core-github-issue-page-size

Conversation

@eamodio

@eamodio eamodio commented Sep 14, 2026

Copy link
Copy Markdown
Member

Summary

  • Honors requested page sizes for account-wide GitHub issue searches. Previously, each of the three aliased searches defaulted to 100 full issue nodes and could exceed GitHub's GraphQL complexity limit.
  • Preserves the existing 100-item default when no size is supplied.
  • Adds facade and GraphQL request regression coverage.

Validation

  • pnpm --filter @gitlens/integrations run test
  • pnpm --filter @gitlens/git-github run test
  • pnpm run build
  • pnpm exec oxfmt --check on all changed files

@eamodio
eamodio requested a review from a team September 14, 2026 03:46
@augmentcode

augmentcode Bot commented Sep 14, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR makes account-wide GitHub issue reads honor the facade's requested page size.

Changes:

  • Adds pageSize to the account-wide issue-read options and forwards itemsPerPage through the integration facade.
  • Passes that value from the GitHub integration into GitHubApi.searchMyIssues and its three aliased GraphQL searches.
  • Preserves the existing 100-node-per-alias default when no page size is supplied.
  • Adds integration and GraphQL-request regression coverage for the forwarding behavior.
  • Documents the complexity-limit fix in the core changelog.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@gitkraken-services

gitkraken-services Bot commented Sep 15, 2026

Copy link
Copy Markdown

Rebase Successful

Skipped — PR is mergeable as-is, no push needed

Summary

Metric Value
Status Clean rebase — no conflicts
Target main
Source bug/core-github-issue-page-size

Generated by Merge Mate at 2026-09-17 18:47:39 UTC

- Prevents GitHub GraphQL complexity failures by threading caller page sizes through every aliased account-wide search.
@eamodio
eamodio force-pushed the bug/core-github-issue-page-size branch from 2bb49e9 to a1273b6 Compare September 16, 2026 15:26
@eamodio
eamodio changed the base branch from main to core September 16, 2026 15:27
@eamodio
eamodio changed the base branch from core to main September 16, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant