Repository navigation
feat(setup): wizard gates on prereqs, probe defaults to No, setup --smoke - #39
Merged
Merged
Conversation
…moke Release-readiness: a fresh user could burn 30 minutes before discovering a missing tool or dead model. Fail fast instead. - Wizard step 0 runs setup::check_all(): missing Required tools bail with fix hints before anything else; missing Recommended only warns. - prompt_llm: "Use it?" now defaults to No unless the probe is fully healthy (model listed + tool call works). A broken model is never an Enter key away (the fledge-alpha-free footgun); unlisted-but-working models warn explicitly. - `kernelopt setup --smoke`: compiles a minimal CUDA kernel with nvcc (or hipcc) to prove the compiler + headers work, independent of --install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-readiness: a fresh user could burn 30 minutes before discovering a missing tool or dead model. Fail fast instead.
Changes
setup::check_all()first. MissingRequiredtools bail immediately with fix hints (run kernelopt setuptable); missingRecommendedonly warns (non---yesmode).--yesmode bails the same way.prompt_llmdefaults to No on unhealthy probe: "Use it?" defaults Yes only when the model is listed AND the tool call works. Unlisted-but-working models get an explicit warning; broken models require an explicity. Closes thefledge-alpha-freefootgun (dead model accepted by pressing Enter).kernelopt setup --smoke: compiles a minimal__global__kernel with nvcc (--ptx) or hipcc (--genco) to prove compiler + headers work — independent of--install, no GPU needed. Verified live:smoke: nvcc compiled a minimal kernel (headers + driver toolchain OK).Validation
cargo build --releaseclean;cargo test122 passed;pytest21 passed.setup --smokeverified live on this box.Notes
docker run) remains the bigger fix for broad-audience onboarding; this PR makes bare-metal fail fast instead.