Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nilas an unavailable encodingReproduction
Compressor.SetEncoderdocuments that an encoder function may returnnilon failure. Before this change, the direct path still selected that encoding and emitted itsContent-Encodingvalue, while the pooled path could panic on an unchecked type assertion whensync.Pool.Newreturnednil.The added tests reproduce both cases with custom encoders that fail deterministically.
Root cause
selectEncoderassumed every configured encoder invocation returned a usable writer. That contradicted the documentedEncoderFuncfailure contract.Solution
Validate encoder results in both selection paths. If construction fails, continue negotiating another accepted encoder; when none succeeds, preserve the identity response without a
Content-Encodingheader.Tests
GOTOOLCHAIN=go1.25.1 go test ./middleware -run '^TestCompressor.*EncoderFailure$' -count=20GOTOOLCHAIN=go1.25.1 go test -race ./middleware -run '^TestCompressor.*EncoderFailure$' -count=3GOTOOLCHAIN=go1.25.1 go vet ./middlewareGOTOOLCHAIN=go1.25.1 make test