Conversation
Replace sleep-based throttle tests with channel handshakes so CI no longer depends on handler duration overlapping request batches (issue 608).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestThrottleBacklog,TestThrottleTriggerGatewayTimeout,TestThrottleMaximum, andTestThrottleRetryAfterstill overlap concurrent requests withtime.Sleepin the handler. On CI that overlap is racy, so the suite fails intermittently even after #1016 (#608).Drive those cases with channel handshakes instead: occupy processing/backlog tokens, then assert success, 429, backlog timeout, context cancel, and
Retry-Afterwithout depending on wall-clock scheduling.TestThrottleCustomStatusCodeis unchanged aside from closing response bodies.Fixes #608
Test plan
go test -race -count=50 -timeout 120s ./middleware -run TestThrottlego test -race -count=1 ./...go vet ./...