Skip to content

do not query max_allowed_packet by default - #680

Merged
julienschmidt merged 1 commit into
masterfrom
max_allowed_packet
Oct 12, 2017
Merged

julienschmidt merged 1 commit into
masterfrom
max_allowed_packet

Conversation

@julienschmidt

Copy link
Copy Markdown
Member

Description

Fixes #499

The default value is from https://dev.mysql.com/doc/en/packet-too-large.html where it says "The server's default max_allowed_packet value is 4MB".

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt julienschmidt added this to the v1.4 milestone Oct 7, 2017

@methane methane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienschmidt
julienschmidt merged commit eb92a8d into master Oct 12, 2017
@julienschmidt
julienschmidt deleted the max_allowed_packet branch October 12, 2017 08:31
bLamarche413 pushed a commit to bLamarche413/mysql that referenced this pull request Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants