Skip to content

Links between top-level deployment nodes in DeploymentView #18

Open
Open
Links between top-level deployment nodes in DeploymentView#18

Description

@jlordiales
jlordiales
opened on Mar 28, 2021

Hi folks!

After a few hours of debugging to figure out why the links between my containers were not being shown in my deployment view, I saw

model/expr/render.go

Lines 101 to 106 in 2461d2e

// Do not automatically add relationship views across different
// top-level deployment nodes.
//
// Note: this rule is a little bit arbitrary however it is possible
// to override the behavior using `Link` and `Unlink` explicitly in
// the design. We'll see how that works out over time.

While it is true that you can technically add them using Link, it's not a great DX. Would you be interested on a PR adding something like AddTopLevelLinks (similar to the current AddAll and AddDefault) that is only applicable inside a DeploymentView?

Activity

  1. raphael commented on Nov 15, 2021

    @raphael
    raphael
    on Nov 15, 2021
    Member

    Sorry for the late reply! Yes that would be a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions