GLTF: Move accessor and buffer view Dictionary conversion into those classes - #108320
Merged
Merged
Conversation
fire
approved these changes
Jul 7, 2025
aaronfranke
force-pushed
the
gltf-buf-accessor-dict
branch
from
July 7, 2025 21:27
32147e6 to
5c99252
Compare
AThousandShips
approved these changes
Jul 8, 2025
aaronfranke
force-pushed
the
gltf-buf-accessor-dict
branch
from
August 22, 2025 17:25
5c99252 to
15b281c
Compare
aaronfranke
force-pushed
the
gltf-buf-accessor-dict
branch
2 times, most recently
from
October 1, 2025 02:38
27850b5 to
0b67b6f
Compare
aaronfranke
force-pushed
the
gltf-buf-accessor-dict
branch
from
October 13, 2025 18:51
0b67b6f to
02182b1
Compare
This was referenced Oct 13, 2025
Contributor
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…sor-dict GLTF: Move accessor and buffer view Dictionary conversion into those classes
wangshucheng
pushed a commit
to wangshucheng/godot
that referenced
this pull request
Aug 27, 2026
…sor-dict GLTF: Move accessor and buffer view Dictionary conversion into those classes
Shane-Gadsby
pushed a commit
to Shane-Gadsby/godotwebgpu
that referenced
this pull request
Sep 21, 2026
…sor-dict GLTF: Move accessor and buffer view Dictionary conversion into those classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the logic currently in GLTFDocument for converting GLTFAccessor to/from Dictionary, and converting GLTFBufferView to/from Dictionary, into those respective classes, and exposes it.
I also renamed some variables for clarity (ex:
si->sparse_indices_dict), and removed some error checks that will never be true (!d.has("buffer")can't happen afterd["buffer"] = ...), but otherwise it is mostly a trivial move, it has the same logic as the existing code.Note that
_get_accessor_type_from_strand_get_accessor_type_nameare duplicated code since their counterparts are still in GLTFDocument for now, but this will be cleaned up later when the rest of the logic is moved into GLTFAccessor.This is part of a refactor to allow using glTF accessors and buffer views from extensions (or just generally outside of GLTFDocument).