Misc cleanup: bump auto-assign action, autoprefixer/postcss-cli, stop tracking generated cli-docs - #744
Misc cleanup: bump auto-assign action, autoprefixer/postcss-cli, stop tracking generated cli-docs#744rossigee wants to merge 1 commit into
Conversation
… tracking generated cli-docs - kentaro-m/auto-assign-action v1.2.4 -> v2.1.2 - autoprefixer 9.7.4 -> 10.5.2, postcss-cli 7.1.2 -> 11.0.1 (fixes npm audit picomatch ReDoS advisory) - content/cli-docs/ is regenerated on every build by cli-docs.sh but was committed to git, causing spurious diffs each time it runs. Add it to .gitignore and untrack the 109 already-committed files. Verified: postcss-cli 11 + autoprefixer 10 process CSS correctly (existing postcss.config.js unchanged), npm audit reports zero vulnerabilities after the bump. Signed-off-by: Ross Golder <ross@golder.org>
Vad1mo
left a comment
There was a problem hiding this comment.
The content/cli-docs/ untracking is correct and I verified it end to end: cli-docs.sh is invoked from load-docs.sh:65, which is make prepare, which both production-build and preview-build depend on. The tracked files were already being overwritten by rsync --delete on every deploy, so published output does not change. Good cleanup.
Two blocking items:
-
kentaro-m/auto-assign-action@v2.1.2does not exist. The latest tag on that repo isv2.0.2;action.yml404s atv2.1.2. Merging this breaks the Auto Assign workflow for every PR after it. This is not caught by CI because the workflow runs onpull_request_target, so the greenadd-reviewscheck here executed the base branch'sv1.2.4, not your change. Please usev2.0.2, and preferably pin to the full commit SHA with a# v2.0.2comment, since this workflow runs with base-repo write permissions. -
postcss-cli@11.0.1declaresengines: {"node": ">=18"}, but.nvmrcon main isv14.11.0and this PR does not change it. The Node bump lives in #745, so this PR is not independent as described. Either add the.nvmrcbump here or drop the postcss-cli bump.
Also note this overlaps entirely with dependabot #756, which bumps the same packages to the same versions and has the same Node constraint. Worth deciding which one carries the dependency change so the other can drop it.
Summary
Split out from #731 per review feedback, as the lowest-risk, independent piece. This does not depend on the other two split-out PRs.
kentaro-m/auto-assign-actionv1.2.4 -> v2.1.2autoprefixer9.7.4 -> 10.5.2 andpostcss-cli7.1.2 -> 11.0.1 (fixes the picomatch ReDoS npm audit advisory)content/cli-docs/is regenerated on every build bycli-docs.shbut was committed to git, causing spurious diffs each run. Added to.gitignoreand untracked the 109 already-committed files.Related
Part of the Hugo/Bulma upgrade work originally proposed in #731, split into independently reviewable pieces per @OrlinVasilev's request there. See also the other two parts:
Test plan
npm auditreports 0 vulnerabilities after the bumppostcss.config.jsunchanged)