You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Missing referenced gateway grants wildcard egress and starts the task #350
A task referencing a nonexistent Gateway is accepted. Worker.processEvent leaves the resolved gateway nil after the lookup fails. Reconcile treats this as no restriction and submits a wildcard egress policy, then resumes the actor.
Reproduction
Create a Task with spec.gateway.name set to does-not-exist, without creating that Gateway. Process its event through Worker.Run.
Observed behavior
The test records an allow-all Substrate egress policy and a ResumeActor call for the task.
Expected behavior
An explicitly referenced gateway must resolve successfully before task execution. A missing reference or lookup failure must not substitute unrestricted egress.
git clone --branch test/review-regressions https://github.com/fkautz/ax.git ax-review
cd ax-review
git checkout 1dc2613d29e12f306154a7e1183c1825a55d24ed
go test ./internal/controller -run '^TestReviewMissingGatewayDoesNotGrantWildcardEgress$' -count=1 -v
Requires the Go toolchain specified by go.mod. The test asserts the desired behavior and fails on the published revision. Production code is unchanged.
This exercises the production API, worker, reconciler, and Substrate client against an in-memory store and stateful in-process gRPC fake. It verifies outbound control RPCs, not packet-level enforcement in a deployed cluster. Related issue #345 concerns hostname TLS blocking and ignored ports, a different failure.
Fix ready: implemented on my fork (branch fix/350-gateway-fail-closed, regression test included, make test green) and ready to PR — but this repo's collaborators_only PR creation policy rejects PRs from non-collaborators (see #358), so I cannot open it. If PR creation opens for external contributors, I will open the PR immediately. Happy to adjust scope per maintainer feedback.
Activity
arbazkhan971 commentedon Sep 22, 2026
Fix ready: implemented on my fork (branch
fix/350-gateway-fail-closed, regression test included,make testgreen) and ready to PR — but this repo'scollaborators_onlyPR creation policy rejects PRs from non-collaborators (see #358), so I cannot open it. If PR creation opens for external contributors, I will open the PR immediately. Happy to adjust scope per maintainer feedback.Add note about pull requests and highlight the early stage (google#350)