Fix CMake 4.0 compatibility. - #68
Merged
Merged
Conversation
|
@pwnall sorry for the direct ping but this fix would allow us to build https://github.com/googleapis/google-cloud-cpp into Apache Arrow without patching out crc32c |
pwnall
self-requested a review
April 7, 2025 23:41
pwnall
approved these changes
Apr 7, 2025
pwnall
left a comment
pwnall
left a comment
Member
There was a problem hiding this comment.
Thank you for linking to the Google C++ library supported versions!
This was referenced Aug 7, 2025
|
@pwnall Can a new version tag perhaps be added to allow building a numbered version using modern CMake? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 4.0 removed compatibility with versions earlier than 3.5. This PR updates
CMakeLists.txtto require at least CMake 3.16, which is the earliest version supported by Google.Some submodules also supported very old CMake versions and caused errors, which were fixed by bumping the submodules.