Skip to content

Fix heap overflow in CopyDataAsFloatImpl by validating accessor bounds #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorvytyaz merged 3 commits into from
Sep 23, 2026
Merged

Fix heap overflow in CopyDataAsFloatImpl by validating accessor bounds #1214

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4844035
Fix heap overflow in CopyDataAsFloatImpl by validating accessor bounds
ztzat089-ctrl Aug 7, 2026
db3d7f5
Merge branch 'main' into fix/gltf-heap-overflow
ztzat089-ctrl Aug 23, 2026
dba80bd
Merge branch 'main' into fix/gltf-heap-overflow
igorvytyaz Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/draco/io/tiny_gltf_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,26 @@ class TinyGltfUtils {
const unsigned char *const data_start =
buffer.data.data() + buffer_view.byteOffset + accessor.byteOffset;
const int byte_stride = accessor.ByteStride(buffer_view);

// Validate that reading |accessor.count| elements with |byte_stride|
// does not read past the end of the buffer.
if (accessor.count < 0 || byte_stride <= 0) {
return Status(Status::DRACO_ERROR,
"Error CopyDataAsFloat() invalid accessor.");
}
const size_t start_offset =
buffer_view.byteOffset + accessor.byteOffset;
if (start_offset > buffer.data.size()) {
return Status(Status::DRACO_ERROR,
"Error CopyDataAsFloat() accessor offset out of bounds.");
}
const size_t available_bytes = buffer.data.size() - start_offset;
const size_t required_bytes =
static_cast<size_t>(byte_stride) * static_cast<size_t>(accessor.count);
if (required_bytes > available_bytes) {
return Status(Status::DRACO_ERROR,
"Error CopyDataAsFloat() accessor data out of bounds.");
}
const int component_size =
tinygltf::GetComponentSizeInBytes(accessor.componentType);

Expand Down
Loading