Skip to content

[No functional change] Delete VJPHiPrimitive and replace with HiPrim. This is a simple replace. #5567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[No functional change] Delete VJPHiPrimitive and replace with HiPrim. This is a simple replace. #5567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions flax/nnx/variablelib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,10 @@ def _new_hijax_from_variable(variable: Variable) -> HijaxVariable:
)
return hijax_var

HiPrim = (hjx.VJPHiPrimitive if jax.__version_info__ <= (0, 11, 1) else
hjx.HiPrim)

class NewVariable(hjx.VJPHiPrimitive):
class NewVariable(HiPrim):
def __init__(self, *leaf_avals, treedef, var_type, ref=False):
self.in_avals = tuple(leaf_avals)
self.out_aval = AbstractVariable(
Expand Down Expand Up @@ -354,7 +356,7 @@ def bind(self, *leaves, treedef, var_type, ref=False):
new_variable_p = _NewVariableShim()


class SetVariable(hjx.VJPHiPrimitive):
class SetVariable(HiPrim):
def __init__(self, hijax_var_aval, *leaf_avals, treedef, var_type):
self.in_avals = (hijax_var_aval, *leaf_avals)
self.out_aval = ()
Expand Down Expand Up @@ -433,7 +435,7 @@ def _set_hijax_state(hijax_var, variable: Variable):
)


class GetVariable(hjx.VJPHiPrimitive):
class GetVariable(HiPrim):
def __init__(self, abstract_var, *, treedef, avals, var_type):
self.in_avals = (abstract_var,)
self.out_aval = tuple(avals)
Expand Down
Loading