Repository navigation
Fix NNX axis metadata under Linen scan and vmap - #5590
Open
Junyi-Zheng wants to merge 1 commit into
Open
Junyi-Zheng wants to merge 1 commit into
Junyi-Zheng wants to merge 1 commit into
Conversation
Update NNXMeta axis metadata through NNX SPMD helpers while preserving values, variable types, and hooks without reinitializing variables. Handle empty metadata tuples and negative mapped axes, and add regression coverage for scan, vmap, sharding, JIT, and gradients. Fixes google#5589
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5589.
NNXMeta.add_axisandremove_axiscurrently do nothing, so Linenscanandvmapcan change variable shapes without updating axis metadata or invoking axis hooks. This can produce incorrect partition specifications and sharding errors.This change:
Validation
test_tabulate_enum, also reproduced on the unmodified baseline.Checklist
NNXMeta.add_axis/remove_axisare no-ops, silently dropping axis metadata under Linenscan/vmap#5589.