Simplify key removal in LegacyProtoTypeAdapterFactoryTest - #3124
Merged
eamonnmcmanus merged 1 commit intoSep 16, 2026
Merged
eamonnmcmanus merged 1 commit into
eamonnmcmanus merged 1 commit into
Conversation
eamonnmcmanus
approved these changes
Sep 16, 2026
eamonnmcmanus
left a comment
eamonnmcmanus
left a comment
Member
There was a problem hiding this comment.
Indeed, I think I had forgotten about removeIf.
Marcono1234
deleted the
marcono1234/LegacyProtoTypeAdapterFactoryTest-simplify
branch
September 17, 2026 09:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Simplify test code
Description
See #3083 (comment)
The code currently does
var keysToRemove = json.keySet().stream()...; json.keySet().removeAll(keysToRemove);. That should be identical tojson.keySet().removeIf(...)(unless I am overlooking something).