Cleanup all the cruft from being a plugin, now we are a dart package with hooks - #264
Merged
Merged
Conversation
Member
Author
|
wow, I did not think I was likely to get CI passing, after all the files I just deleted 🙈 |
HamdaanAliQuatil
requested changes
Apr 30, 2026
Member
Author
|
maybe we should disable firefox testing on mac os, it seems to fail a bit intermittently. And honestly, testing firefox on Linux is probably good enough. |
Co-authored-by: HamdaanAliQuatil <96776914+HamdaanAliQuatil@users.noreply.github.com>
HamdaanAliQuatil
approved these changes
May 1, 2026
HamdaanAliQuatil
left a comment
HamdaanAliQuatil
left a comment
Collaborator
There was a problem hiding this comment.
Looks good!
Nice to finally have webcrypto as a Dart package with hooks :)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to remove all the plugin left-over and rely exclusively on native hooks.
I had to re-create the example/, because the templates change so much that I couldn't keep up.
everything in example/ is boilerplate flutter except:
lib/main.dart(copied from the old example)integration_test/pubspec.yaml