fix(rsa): validate modulus length before browser interop - #388
Merged
HamdaanAliQuatil merged 1 commit intoSep 3, 2026
Merged
HamdaanAliQuatil merged 1 commit into
HamdaanAliQuatil merged 1 commit into
Conversation
HamdaanAliQuatil
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modulusLengthagainst the WebIDL unsigned-long range before backend dispatchMotivation
The browser backend previously forwarded out-of-range
modulusLengthvalues toSubtleCrypto.generateKey. WebIDL conversion failures then escaped through Dart2JS as rawJSObject: TypeErrorvalues.Validating at the shared public API boundary produces a consistent Dart
ArgumentErrorbefore browser interop and avoids duplicating checks in individual backends.Testing
dart analyze --fatal-warnings .dart test test/webcrypto_test.dart -p vmdart test test/webcrypto_test.dart -p chrome -c dart2jsdart test test/webcrypto_test.dart -p chrome -c dart2wasmdart format --output=none --set-exit-if-changedon all changed Dart filesgit diff --checkFixes #387