Skip to content

Create variant of google-cloud-java with Guava and grpc-stub shaded #1573

Description

@garrettjonesgoogle

Note: GAX needs to be exposed.

Consequences:

  1. Guava can't be exposed on the public surface of GAX or google-cloud-java
  2. grpc-stub can't be exposed on the public surface of GAX or google-cloud-java (since it exposes Guava)
  3. The generated grpc packages need to be split into two: a package with proto-generated types (no Guava dependency) and a package with only grpc (which exposes Guava), and the second type of package needs to be shaded.

Coordinating issue in GAX is filed at googleapis/gax-java#188 .

Also: protobuf-java-util needs to be shaded.

@VisibleForTesting needs to be removed throughout the code.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: loggingIssues related to the Cloud Logging API.api: pubsubIssues related to the Pub/Sub API.dependenciestype: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions