Skip to content

TraceServiceSettings.Builder not very idiomatic #2610

Description

@joaoandremartins

I'm having to do this weird cast, which should be avoidable:

TraceServiceClient.create(
	((TraceServiceSettings.Builder) TraceServiceSettings.newBuilder()
	.setCredentialsProvider(
		StackdriverTraceAutoConfiguration.this.finalCredentialsProvider)
	.setExecutorProvider(executorProvider))
	.build())

Notice the (TraceServiceSettings.Builder) cast, because setExecutorProvider() is inherited from the abstract ClientSettings and should probably be overwritten to return a TraceServiceSettings.Builder.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

type: questionRequest for information or clarification. Not an issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions