Skip to content

Make sure failsafe and surefire plugin versions match - #7029

Merged
skuruppu merged 1 commit into
googleapis:masterfrom
chingor13:failsafe-versions
Dec 19, 2019
Merged

Make sure failsafe and surefire plugin versions match#7029
skuruppu merged 1 commit into
googleapis:masterfrom
chingor13:failsafe-versions

Conversation

@chingor13

@chingor13 chingor13 commented Dec 11, 2019

Copy link
Copy Markdown
Contributor

Fixes #6968

This also fixes an issue where spanner integration tests hang - likely because of a mismatch of maven surefire and failsafe plugin versions.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2019
@codecov

codecov Bot commented Dec 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #7029 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7029      +/-   ##
============================================
- Coverage     32.15%   32.14%   -0.01%     
+ Complexity     3694     3693       -1     
============================================
  Files           248      248              
  Lines         40347    40347              
  Branches       6129     6129              
============================================
- Hits          12972    12970       -2     
- Misses        26309    26310       +1     
- Partials       1066     1067       +1
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 86% <0%> (-1%) 36% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23988a5...bf9074a. Read the comment docs.

@chingor13
chingor13 marked this pull request as ready for review December 11, 2019 18:50

@skuruppu skuruppu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I confirmed by running it that it works.

@skuruppu
skuruppu merged commit b6a364a into googleapis:master Dec 19, 2019
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

General: Failsafe Plugin M3 cannot find Surefire class

3 participants