Add vision GAPIC - #463
Merged
Merged
Conversation
googlebot
added
the
cla: yes
dwsupplee
approved these changes
Apr 25, 2017
dwsupplee
left a comment
dwsupplee
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Is there anything else we need or can this be merged and set up for a release?
jdpedrie
reviewed
Apr 25, 2017
| ], | ||
| "nav": [{ | ||
| "title": "VisionClient", | ||
| "type": "vision/v1/visionclient" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| "vision/v1/\\w{1,}" | ||
| ], | ||
| "nav": [{ | ||
| "title": "VisionClient", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Is the TOC incorrect, or the gapic client name? |
Contributor
Author
|
@jdpedrie Good spot, the TOC was incorrect, updated. @dwsupplee I don't think we need anything else. |
Contributor
|
LGTM! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for doc generation coming