Skip to content

Run system tests on merge - #485

Closed
michaelbausor wants to merge 1 commit into
googleapis:masterfrom
michaelbausor:update-travis
Closed

Run system tests on merge#485
michaelbausor wants to merge 1 commit into
googleapis:masterfrom
michaelbausor:update-travis

Conversation

@michaelbausor

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 11, 2017
@michaelbausor

Copy link
Copy Markdown
Contributor Author

Did we conclude that this change should be included for now?

@jdpedrie

jdpedrie commented May 30, 2017

Copy link
Copy Markdown
Contributor

What do you think about running them on a daily cron instead?

  • Doesn't significantly slow down many builds.
  • Doesn't impact the flurry of builds at release.
  • Gives us ongoing alerts of problems which may arise due to changes in the service, even when no changes are made in the library for a period of time.

@michaelbausor

Copy link
Copy Markdown
Contributor Author

I think that this is a very reasonable approach - I am definitely happy to try that out rather than running on merge.

@michaelbausor

Copy link
Copy Markdown
Contributor Author

Closing for now - can reopen if/when required

Hectorhammett pushed a commit that referenced this pull request Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants