Add BigQuery Routine by quartzmo · Pull Request #4707 · googleapis/google-cloud-ruby

quartzmo · 2020-01-21T17:52:39Z

See googleapis/google-cloud-python#8491 for an example.

closes: #4430

googlebot · 2020-01-21T17:52:45Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2020-01-21T20:31:08Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2020-01-23T18:11:24Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2020-01-28T03:26:22Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2020-01-29T00:38:11Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

shollyman

Thanks for putting this together. Added comments, reviewing this helped me realize we need to revisit filter / readmask for the initial implementations where missing.

shollyman · 2020-02-05T21:30:06Z

+      class Routine
+        ##
+        # Routine::List is a special case Array with additional values.
+        class List < DelegateClass(::Array)


It looks like this is missing support for supported list params. Added a comment to the impl guide because I realized the docs weren't properly exposing their presence.

shollyman · 2020-02-05T21:33:11Z

+
+    routines.count.must_equal 6
+    routines.each { |ds| ds.must_be_kind_of Google::Cloud::Bigquery::Routine }
+  end


possibly want an list test in this test set that leverages filter once it is available.

quartzmo · 2020-02-05T22:06:31Z

@shollyman:

we need to revisit filter / readmask for the initial implementations where missing.

I'll start work now on adding the filter property to restrict what types of entities are returned by the routines.list method (e.g. only list UDFs, or stored procedures).

Is the readmask also appropriate/desired in the ruby client? You probably noticed that this client has a somewhat elaborate mechanism for transitioning an object from a partial to a full projection. I'm not sure how this will interact with a readmask for routines.list since the detection of the partial projection state depends on the presence of a field that is missing in the default partial project from the list but required in the full projection.

quartzmo · 2020-02-07T22:12:28Z

@shollyman I added filter to Dataset#routines (Routine::List) as well as QueryJob#ddl_target_routine (statistics).

quartzmo · 2020-02-10T22:48:48Z

@shollyman PTAL, let me know if you want anything else in this PR, or if it's ready for @dazuma to review. Thanks!

googlebot · 2020-02-10T22:51:11Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

shollyman · 2020-02-11T00:32:24Z

@shollyman PTAL, let me know if you want anything else in this PR, or if it's ready for @dazuma to review. Thanks!

Thanks, it looks good from my perspective. I concur with the read mask being of lesser value here given you've got a much more stateful implementation to deal with here.

blowmage · 2020-02-11T01:44:01Z

@googlebot I consent.

googlebot · 2020-02-11T18:01:12Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

…ented RuntimeError

…s to options hash

blowmage and others added 5 commits January 20, 2020 14:43

wip

a5e3de5

wip2

31cdc69

Add Routine acceptance test

785f066

Add create_routine

f1f355e

Add Routine::List and #update_routine

7b4fb51

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 21, 2020

quartzmo added api: bigquery Issues related to the BigQuery API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jan 21, 2020

quartzmo self-assigned this Jan 21, 2020

quartzmo requested review from a team and shollyman January 21, 2020 17:53

dazuma added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 21, 2020

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 23, 2020

Add Routine unit tests

f3ff1f9

quartzmo force-pushed the bigquery-routine branch from 00e3b70 to f3ff1f9 Compare January 23, 2020 18:11

Add Routine resource methods

69e20cd

dazuma added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 28, 2020

Update Routine and tests

4e100f1

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 29, 2020

Completed Routine unit tests and doctest

0bed1f9

quartzmo force-pushed the bigquery-routine branch from 97b2897 to 0bed1f9 Compare January 30, 2020 22:32

quartzmo added 5 commits February 3, 2020 18:53

Finish update of StandardSql types

ee509b8

Add Routine#update

6c6d86e

Update docs

61e19dd

Rename Routine#type to Routine#routine_type

6b58ddb

Update Routine docs

ea0b4d4

shollyman reviewed Feb 5, 2020

View reviewed changes

Complete docs for Argument and StandardSql

f96325d

quartzmo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 6, 2020

quartzmo added 2 commits February 7, 2020 14:17

Add filter to Dataset#routines

3278898

Add Data#ddl_target_routine and QueryJob#ddl_target_routine

5f3618f

dazuma added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 10, 2020

quartzmo requested a review from dazuma February 11, 2020 00:53

dazuma suggested changes Feb 11, 2020

View reviewed changes

quartzmo added 4 commits February 11, 2020 08:43

Update all test fixtures to squiggly heredoc

d20597e

Update force param default in all #exists? methods to false

24bff50

Update Routine docs return types for reference state

3b8a9a5

Update options = {} to keyword arguments or **kwargs

5fe33e7

quartzmo added 2 commits February 11, 2020 13:28

Override lifecycle methods in Updater subclasses to return not implem…

ab68c7f

…ented RuntimeError

Restore CopyJob.from_options and ExtractJob.from_options from **kwarg…

887cb3a

…s to options hash

dazuma approved these changes Feb 11, 2020

View reviewed changes

quartzmo merged commit a5b2c0d into googleapis:master Feb 11, 2020

quartzmo deleted the bigquery-routine branch February 11, 2020 22:55

Uh oh!

Conversation

quartzmo commented Jan 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Jan 21, 2020

Uh oh!

googlebot commented Jan 21, 2020

Uh oh!

googlebot commented Jan 23, 2020

Uh oh!

googlebot commented Jan 28, 2020

Uh oh!

googlebot commented Jan 29, 2020

Uh oh!

shollyman left a comment

Choose a reason for hiding this comment

Uh oh!

shollyman Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

shollyman Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

quartzmo commented Feb 5, 2020

Uh oh!

quartzmo commented Feb 7, 2020

Uh oh!

quartzmo commented Feb 10, 2020

Uh oh!

googlebot commented Feb 10, 2020

Uh oh!

shollyman commented Feb 11, 2020

Uh oh!

blowmage commented Feb 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

googlebot commented Feb 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

quartzmo commented Jan 21, 2020 •

edited

Loading