fix: preserve explicit false SSL options#2639
Open
fengjikui wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
06b26cf to
11476b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2557.
Summary
client_args={"verify": False}/async_client_args={"verify": False}asFalsefor httpxasync_client_args={"ssl": False}asFalsefor aiohttp and websocket pathsFalsecasesRoot cause
The SSL helpers used truthiness checks such as
if not ctxandif not args.get(...). That makes an explicitFalseindistinguishable from an unset option, so the SDK replaced the user's disabled-verification setting with a defaultssl.SSLContext.Validation
env -u HTTP_PROXY -u HTTPS_PROXY -u ALL_PROXY -u http_proxy -u https_proxy -u all_proxy .venv/bin/python -m pytest google/genai/tests/client/test_client_initialization.py::test_client_ssl_context_implicit_initialization google/genai/tests/client/test_client_initialization.py::test_client_ssl_context_explicit_initialization_same_args google/genai/tests/client/test_client_initialization.py::test_client_ssl_context_explicit_initialization_separate_args google/genai/tests/client/test_client_initialization.py::test_client_ssl_context_explicit_initialization_sync_args google/genai/tests/client/test_client_initialization.py::test_client_ssl_context_explicit_initialization_async_args google/genai/tests/client/test_client_initialization.py::test_client_ssl_context_preserves_explicit_false_httpx_verify google/genai/tests/client/test_client_initialization.py::test_client_ssl_context_preserves_explicit_false_aiohttp_ssl google/genai/tests/client/test_client_initialization.py::test_client_ssl_context_preserves_explicit_false_websocket_ssl -q(10 passed)env -u HTTP_PROXY -u HTTPS_PROXY -u ALL_PROXY -u http_proxy -u https_proxy -u all_proxy .venv/bin/python -m pytest google/genai/tests/client/test_client_initialization.py -q(90 passed)git diff --check