Add CMEK arguments to client.batches.create#2643
Open
matt-davis27 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
06d9f72 to
5190a64
Compare
5190a64 to
2a91889
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2622.
Add Customer Managed Encryption Key [CMEK] arguments to client.batches.create (which allows the user to set the keys directly in the configuration of a new batch job)
Summary of Changes
types.py — Added
encryption_specfield to both:CreateBatchJobConfig(pydantic model) — acceptsEncryptionSpecor dictCreateBatchJobConfigDict(TypedDict) — acceptsEncryptionSpecDictbatches.py — Added mapping in
_CreateBatchJobConfig_to_vertexthat convertsencryption_spec.kms_key_nametoencryptionSpec.kmsKeyNameon the API request body.tests/batches/test_create_with_cmek.py — new test file to ensure CMEK arguments are parsed correctly and added to batch job.
Usage
You can now add CMEK to your batch job config in one of two ways: