Improve password manager autofill compatibility#326
Merged
Conversation
jmattheis
approved these changes
Nov 25, 2023
jmattheis
left a comment
jmattheis
left a comment
Member
There was a problem hiding this comment.
For me it already worked previously, but only on the first try because then the autofill option disappeared somehow. With your changes it works more consistently and the option to auto fill is always visible. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the automatic input of username and password.
Previously my manager did not recognize the username input field and focused only on the url and password fields.
Please check (if you use a password manager) if that works fine for you.
It's the last PR for now :)