Correct swizzle assignment on pointer tests#4682
Merged
sudonatalie merged 1 commit intoJul 16, 2026
Merged
Conversation
The swizzle assignment spec was updated so that creating a SwizzleView from pointer requires support for pointer_composite_access, so CTS tests here are updated to correctly handle the interaction between swizzle_assignment and pointer_composite_access. Execution tests for swizzle assignment via pointer are now skipped if the pointer_composite_access language feature is not available, and validation tests are added to validate both cases. Bug: crbug.com/534329233
alan-baker
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The swizzle assignment spec was updated so that creating a SwizzleView from pointer requires support for pointer_composite_access, so CTS tests here are updated to correctly handle the interaction between swizzle_assignment and pointer_composite_access. Execution tests for swizzle assignment via pointer are now skipped if the pointer_composite_access language feature is not available, and validation tests are added to validate both cases.
Bug: crbug.com/534329233
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.