Skip to content

Fix pipeline_immediate:required_slots#4683

Merged
dneto0 merged 2 commits into
gpuweb:mainfrom
alan-baker:no-immediate-arrays
Jul 17, 2026
Merged

Fix pipeline_immediate:required_slots#4683
dneto0 merged 2 commits into
gpuweb:mainfrom
alan-baker:no-immediate-arrays

Conversation

@alan-baker

@alan-baker alan-baker commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
  • Arrays cannot be used in immediate variables so switch to dynamic indexing of a vector

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

* Arrays cannot be used in immediate variables so switch to dynamic
  indexing of a vector
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Results for build job (at 1f21d1c):

 Test case/subcase counts did not change.

@dneto0 dneto0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@dneto0
dneto0 merged commit 8dc1004 into gpuweb:main Jul 17, 2026
1 check passed
@alan-baker
alan-baker deleted the no-immediate-arrays branch July 17, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants