feat: extract private scheduler package and prove inlining - #340
Open
draedful wants to merge 1 commit into
Open
Conversation
Reviewer's GuideThe PR relocates scheduler behavior and tests into a private workspace package, keeps the scheduler types and APIs publicly owned by File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ESchedulerPriority,schedule,debounce, andthrottlepublicly owned and exported only by@gravity-ui/graphValidation
CI=1 pnpm install --frozen-lockfilepnpm run lintpnpm run typecheckpnpm run testpnpm run build-storybookpnpm run test:package-contractCI=1 pnpm run test:e2e:ci— 186 passedCloses #321
Summary by Sourcery
Extract the scheduler into a private workspace package while preserving the public graph scheduler API and enforcing that the implementation is fully inlined into published output.
New Features:
@gravity-ui/graphpackage while keeping their implementation private.Enhancements:
Build:
Documentation:
Tests: