Skip to content

Support stroke dash#81

Closed
You-J wants to merge 1 commit into
mainfrom
support-stroke-dash
Closed

Support stroke dash#81
You-J wants to merge 1 commit into
mainfrom
support-stroke-dash

Conversation

@You-J

@You-J You-J commented Nov 18, 2021

Copy link
Copy Markdown
Collaborator

Support stroke style - dash

// wip

@vercel

vercel Bot commented Nov 18, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/grida/designto-codes/BpMd5VpBBu4QBL5Zh9e1Q5W2aXwQ
✅ Preview: Failed

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@You-J

You-J commented Nov 18, 2021

Copy link
Copy Markdown
Collaborator Author

According to figma api, information related to stroke is as follows.

strokes: [
      {
        blendMode: "NORMAL",
        type: "SOLID",
        color: {
          r: 1,
          g: 0,
          b: 0,
          a: 1,
        },
      },
    ],
    strokeWeight: 1,
    strokeAlign: "INSIDE",
    strokeDashes: [2, 2],

You can check strokeDashes is of type number[] it at https://www.figma.com/developers/api. But in [plugin-docs]https://www.figma.com/plugin-docs/api/VectorNode/#dashpattern there is only dashpattern.
I need to check a little more about the solution as to which one is right and if I need to modify the design-sdk or have a converter in the middle.

ref - https://forum.figma.com/t/dashed-strokes/5796

figma forum link - https://forum.figma.com/t/what-different-stroke-dash-dashpattern-and-strokedashes/10494

@softmarshmallow

Copy link
Copy Markdown
Member

Muted by #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants