Support idle connection timeout with pending sockets - #2213
Merged
Merged
Conversation
Member
Author
|
cc @jhyuzhijian @kalduzov |
Member
Author
Why not? Kestrel has a default keep-alive timeout of 130 seconds. |
|
all right,i will test it |
|
We currently have 3 services in testing. On two of them, such an error occurs and they do not actively load the channel. Now about 1 error per hour. The third one is actively working with Grpc and there have been no such errors in the last 24 hours. This partly confirms what you're thinking @JamesNK . |
mgravell
reviewed
Jul 28, 2023
mgravell
approved these changes
Jul 28, 2023
mgravell
left a comment
Contributor
There was a problem hiding this comment.
nit on naming (this is a "consider", not a "please change"), but: LGTM
This was referenced Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2210
I think the issue is caused by a race when there is a long time interval between a channel connecting and a request being made:
The prospective fix is to close and recreate the socket if it exceeds the idle connection timeout. Default of 1 minute.