Skip to content

Stabilize unobserved exception retry test - #2758

Merged
JamesNK merged 3 commits into
grpc:masterfrom
JamesNK:fix-net462-unobserved-exception-test
Aug 17, 2026
Merged

JamesNK merged 3 commits into
grpc:masterfrom
JamesNK:fix-net462-unobserved-exception-test

Conversation

@JamesNK

@JamesNK JamesNK commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

  • wait for the expected unobserved exception using the shared bounded retry helper
  • retain the existing fixed observation window for cases that expect no unobserved exceptions
  • prevent a late-finalized exception from leaking into the next parameterized net462 case

The failure was unrelated to the triggering Dependabot change. The positive case could finish its five GC cycles before its faulted response task was finalized, causing that exception to be reported by the following case.

Tests

  • focused AsyncUnaryCall_CallFailed_NoUnobservedExceptions: 42 passed
  • focused net462 test, repeated 20 times: passed
  • full Grpc.Net.Client.Tests net462 suite, repeated 5 times: passed
  • git diff --check

@JamesNK
JamesNK requested a review from BrennanConroy August 15, 2026 00:57
@JamesNK
JamesNK merged commit 74de8ca into grpc:master Aug 17, 2026
4 of 5 checks passed
@JamesNK
JamesNK deleted the fix-net462-unobserved-exception-test branch August 17, 2026 03:01
This was referenced Sep 21, 2026
This was referenced Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants