s2a: Address comments on S2A channel + stub - #11584
Merged
Merged
Conversation
rmehta19
marked this pull request as draft
October 2, 2024 00:06
rmehta19
force-pushed
the
s2a-delete-handshaker-class
branch
from
October 2, 2024 04:45
5c6f61a to
f757461
Compare
rmehta19
marked this pull request as ready for review
October 2, 2024 05:27
ejona86
approved these changes
Oct 2, 2024
larry-safran
approved these changes
Oct 2, 2024
larry-safran
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
kannanjgithub
pushed a commit
to kannanjgithub/grpc-java
that referenced
this pull request
Oct 23, 2024
* delete HandshakerServiceChannel. * remove usage of S2AGrpcChannelPool + avoid creating Channel ref per conn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address discussions: