Skip to content

Combining streams recipe doesn't work #251

Description

@callumlocke

Combining streams to handle errors

The line combined.on('error', function(err) {...}); just throws an error:

TypeError: Object function (){
    return pipeline.apply(pipeline, args);
  } has no method 'on'

Activity

  1. callumlocke commented on Feb 7, 2014

    @callumlocke
    ContributorAuthor

    Also, it would be good to see a bit more documentation about errors generally, especially in the context of gulp.watch.

  2. tomasdev commented on Feb 7, 2014

    @tomasdev

    👍 specially on require('gulp-util').combine versus require('event-stream').concat which seem similar.

  3. yocontra commented on Feb 8, 2014

    @yocontra
    Member

    Will take a PR to correct the docs. I'd like to change that page to use the lazypipe module instead of gulp-util. I'm traveling ATM so won't have time to do this

  4. tomasdev commented on Feb 8, 2014

    @tomasdev

    @contra just tell me what is the correct usage and I'll make the PR

  5. added a commit that references this issue on Feb 8, 2014
  6. yocontra commented on Feb 8, 2014

    @yocontra
    Member

    @tomasdev Do you think you could modify the example to use lazypipe instead? The problem with gutil.combine is that the streams are only created once so once they end the factory will quit working

  7. tomasdev commented on Feb 8, 2014

    @tomasdev

    @contra you mean like https://gist.github.com/OverZealous/8503130 or multipipe? or es.concat/merge?

  8. yocontra commented on Feb 8, 2014

    @yocontra
    Member
  9. added a commit that references this issue on Feb 8, 2014
    0649f59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions