Skip to content

Replacing an invalid return statement with a valid exit code and allowing gulp to be run anywhere within a project. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsdevel wants to merge 2 commits into from
Closed

Replacing an invalid return statement with a valid exit code and allowing gulp to be run anywhere within a project. #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3932425
Replacing an invalid return statement with a valid exit code.
jsdevel Nov 13, 2013
36de59f
gulp may be run anywhere within a project.
jsdevel Nov 13, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 30 additions & 16 deletions bin/gulp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@ var chalk = require('chalk');
var resolve = require('resolve');

var tasks = argv._;
var gulpFile = getGulpFile(process.cwd());
var initialCwd = process.cwd();
var gulpFile = getGulpFileAndChangeCwd(initialCwd);
var cliPkg = require('../package.json');
var cliGulp = require('../');

if (!gulpFile) {
cliGulp.log(chalk.red('No Gulpfile found'));
return;
cliGulp.log(chalk.red('No Gulpfile found in any parent directory starting at: '+initialCwd));
process.exit(1);
}

// find the local gulp
Expand Down Expand Up @@ -74,16 +75,29 @@ function loadGulpFile(localGulp, gulpFile, tasks){
return theGulpfile;
}

function getGulpFile(baseDir) {
var extensions = Object.keys(require.extensions);
var Gulpfiles = extensions.map(function(ext){
return path.join(baseDir, "Gulpfile" + ext);
});

var gulpFiles = extensions.map(function(ext){
return path.join(baseDir, "gulpfile" + ext);
});

return gulpFiles.concat(Gulpfiles)
.filter(fs.existsSync)[0];
}
function getGulpFileAndChangeCwd(baseDir) {
var processed={};
var proposedPath;
var gulpFile;

while(!(baseDir in processed)){
processed[baseDir]=1;

proposedPath = path.resolve(baseDir, "Gulpfile.js");
if(fs.existsSync(proposedPath)){
gulpFile=proposedPath;
} else {
proposedPath = path.resolve(baseDir, "gulpfile.js");
if(fs.existsSync(proposedPath)){
gulpFile=proposedPath;
}
}

if(gulpFile){
process.chdir(baseDir);
return gulpFile;
}
baseDir = path.resolve(baseDir, '..');
}
return null;
}