Query param matching with empty values? #181

Activity

1. plaes commented on Apr 27, 2026

   

   plaes

   on Apr 27, 2026

   Author

   More actions

   Not sure whether this is an acceptable patch, considering that there's also a param_exists(name, allow_empty=False)?

   diff --git a/src/pook/matchers/query.py b/src/pook/matchers/query.py
   index 185ac9f..78b8b7b 100644
   --- a/src/pook/matchers/query.py
   +++ b/src/pook/matchers/query.py
   @@ -30,14 +30,14 @@ class QueryMatcher(BaseMatcher):
    
            # Parse and assert type
            if isinstance(query, str):
   -            query = parse_qs(self.expectation)
   +            query = parse_qs(self.expectation, keep_blank_values=True)
    
            # Validate query params
            if not isinstance(query, dict):
                raise ValueError("query params must be a str or dict")
    
            # Parse request URL query
   -        req_query = parse_qs(req.url.query)
   +        req_query = parse_qs(req.url.query, keep_blank_values=True)
    
            # Match query params
            return self.match_query(query, req_query)
   diff --git a/tests/unit/mock_test.py b/tests/unit/mock_test.py
   index f195893..0aef05c 100644
   --- a/tests/unit/mock_test.py
   +++ b/tests/unit/mock_test.py
   @@ -111,6 +111,11 @@ def test_mock_constructor(param_kwargs, query_string, url_404):
                "?baz=qux",
                (False, []),
            ),
   +        (
   +            {"foo": ""},
   +            "?foo",
   +            (True, [])
   +        ),
        ],
    )
    def test_mock_params(url_404, params, req_params, expected, mock):
2. jharibo

   added a commit that references this issue on Oct 21, 2026

   matchers/query: keep blank values when parsing query strings

   ...

   b470e08
3. jharibo commented on Oct 21, 2026

   

   jharibo

   on Oct 21, 2026

   More actions

   Fixed in pookx 2.2.2, a maintained fork of pook that keeps the pook import name. Both parse_qs calls now keep blank values, as suggested above, with docs and tests from #188. Note that an empty value requires the parameter to be present: params({"cursor": ""}) matches ?cursor= but not a request without cursor. More context in #186.