Repository navigation
Add venue_name filter to Events API v1 - #781
Open
oliviasculley wants to merge 9 commits into
Open
oliviasculley wants to merge 9 commits into
oliviasculley wants to merge 9 commits into
Conversation
irby
approved these changes
Sep 14, 2026
allella
requested changes
Sep 14, 2026
allella
left a comment
allella
left a comment
Member
There was a problem hiding this comment.
I posted the venue data in the #hg-labs and added a comment that we might consider using a venue slug that's generated once on input so we're not doing and O(n) real-time conversion on every row in the venue table to find lower case.
If we get to normalizing the venues on input, that slug could be a cleaner way for people like Jen to query than a venue id or title.
If we had a venue slug, then we could also run the normalized user input through the whereLikeContains() macro that's part of the pending maps API pull request to sanitize.
allella
reviewed
Sep 14, 2026
allella
requested changes
Sep 15, 2026
irby
reviewed
Sep 15, 2026
Allow GET /api/v1/events to filter by venue name with a partial, case-insensitive match that ignores spaces so queries like "openworks" match venues named "Open Works". Closes hackgvl#780
Store a venue slug (editable in Filament, auto-generated from the name) and expose it on GET /api/v1/events so consumers can filter with venue_slug instead of converting names at query time.
oliviasculley
force-pushed
the
feat/api-filter-venue-name
branch
from
October 4, 2026 01:32
6693454 to
5cba5e5
Compare
Stop creating a new venue whenever the address or coordinates drift, and stop overwriting a custom slug on import.
irby
reviewed
Oct 12, 2026
The backfill now uses the same helper as the importer and the Filament form, so blank and messy slugs stay consistent.
irby
approved these changes
Oct 13, 2026
allella
approved these changes
Oct 13, 2026
Keep the dynamic Scribe base URL from develop and the venue_slug example on the v1 events curl sample.
Member
|
I think we can merge this and test on stage. Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
venue_namequery parameter toGET /api/v1/eventsso consumers can filter events by location name.This is a partial, case-insensitive match that also ignores spaces, covering the SynergyMill / Open Works use case from #780. For example,
venue_name=openworksmatches a venue namedOpen Works.v0 is unchanged; that version is legacy and does not take new filters.
Usage
The parameter is documented in
/docs/apialongside the existingvenue_cityandvenue_statefilters.Test plan
php artisan test app-modules/api/tests/Feature/EventApiV1Test.php/docs/api, confirmvenue_nameappears on the v1 events endpoint and Try it out filters as expectedCloses #780