Repository navigation
rocm,vulkan: improve Qwen3.8 Flash prompt processing on Strix Halo - #11
Closed
gaetan-puleo wants to merge 3 commits into
Closed
gaetan-puleo wants to merge 3 commits into
gaetan-puleo wants to merge 3 commits into
Conversation
Assisted-by: OpenCode
Assisted-by: OpenCode
dzannotti
approved these changes
Aug 30, 2026
gaetan-puleo
pushed a commit
to rcfa/strix-llama.cpp
that referenced
this pull request
Oct 16, 2026
halo-box#11) Co-authored-by: Marshall <assistant@llama.cpp> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit afd0627)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves Qwen3.8-Flash-Next PP2048 prompt-processing performance on AMD Strix Halo for both ROCm and Vulkan.
The ROCm changes optimize the production shapes used by:
The Vulkan changes optimize:
The changes are restricted to measured AMD or Strix Halo paths and production Qwen3.8 shapes. Other devices retain their existing selection logic.
This PR does not include the commits, corpus fixtures, or
AGENTS.mdchanges fromcorrectness/vulkan-mmv-and-agent-flow.Measurements
Device: Ryzen AI Max+ 395 / Radeon 8060S
Memory: 128 GB unified LPDDR5X
Power: not recorded
BIOS: UMA split not recorded
Kernel: 7.1.8-200.fc44.x86_64
Backends: ROCm 7.14, Vulkan RADV
ROCm build: Release, GGML_HIP=ON, AMDGPU_TARGETS=gfx1151
Vulkan: Release, GGML_VULKAN=ON
Baseline: 6c84c7d
Change: a7ad7b7
Branch: qwen-3.8-flash-pp-improvement
Model: Qwen3.8-Flash-Next-UD-IQ4_XS, 176.9B parameters, 4.25 bpw
Settings: PP2048, batch=2048, ubatch=2048, F16 K/V, Flash Attention enabled
Repeats: 4
ROCm
Vulkan
Benchmark command:
llama-bench -m MODEL -p 2048 -d 0,12000,32000,64000 -b 2048 -ub 2048 -n 0 -r 4 -ngl 99 -fa on -ctk f16 -ctv f16 --load-mode none -o jsonlImplementation
ROCm changes include:
mm_idsprocessingVulkan changes include:
Correctness
The optimized builds were compared with separately built reference binaries using identical model, prompt, tokenization, batch, KV, Flash Attention, and offload settings.
4631827e942084c116fcea4fb5e30df4f37585797e4e6a7f8880ad24dd71b681aaa573fbcea43753939c6dfd7b4d271bbd1585140c55e6e61fd5abad6311dcdeThe complete Vulkan suite reported 17335/17338. The same three exact-batch matmul failures reproduce on the stock implementation with the same tests, so no candidate-only failure was found.
Faster Flash Attention tile experiments were rejected because they changed final logits.
The pre-existing Vulkan MMV split behavior from
ca94157f7is addressed by a separate correctness PR and is intentionally not included here.Additional information
What was not verified:
llama-benchymaster; the recorded baseline is6c84c7d5dRequirements